Add REMOTE_ALLOC_ALLOWED_PORT_RANGE for remote alloc #1533
+276
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
In v0, there are 4 ports are "frontend" ports, which would be accessed by other hosts:
* on the client host,
* alloc serve port
* proc mesh' router port.
* on the worker host,
* allocator serve port
* forwarder port
We want these port's `ChannelAddr`s to use consistent IP addresses, i.e.
* on the client host, router port should use the same IP address as alloc serve port
* on the worker host, forwarder port should use the same IP address as allocator serve port, which was known to client host.
This is important because otherwise the IP address will be generated through `channel::any`, which would get the private IP address. In some environments, e.g. in aws, we could have:
* client host and worker host are on different subnets, and they can only talk to each other through the public address.
Using the same IP address consistently would make it easy to guarantee the correct address type is used throughout the hosts.
Differential Revision: D84614744
Differential Revision: D84633997
Differential Revision: D84636054
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D84636054