Use pytest-isolate to make tests more reliable #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84636534. |
meta-cla
bot
added
the
CLA Signed
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 14, 2025
Summary: The pytest-isolate package can support both pytest-timeout and pytest-forked, to run each test in a separate process. This should help prevent cross-contamination (one test affects a second test), as well as preventing tests with fatal signals from taking down the whole test run. It requires pytest-timeout to *not* be installed, or else that will take precedence. https://pypi.org/project/pytest-isolate/ Differential Revision: D84636534
dulinriley
force-pushed
the
export-D84636534
branch
2 times, most recently
from
6b254d1 to
24db257
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Oct 14, 2025
Summary: The pytest-isolate package can support both pytest-timeout and pytest-forked, to run each test in a separate process. This should help prevent cross-contamination (one test affects a second test), as well as preventing tests with fatal signals from taking down the whole test run. It requires pytest-timeout to *not* be installed, or else that will take precedence. https://pypi.org/project/pytest-isolate/ Differential Revision: D84636534
Summary: The pytest-isolate package can support both pytest-timeout and pytest-forked, to run each test in a separate process. This should help prevent cross-contamination (one test affects a second test), as well as preventing tests with fatal signals from taking down the whole test run. It requires pytest-timeout to *not* be installed, or else that will take precedence. Since this slows down tests, but makes them easier to reproduce, we can turn on `-n auto` to run them in parallel. https://pypi.org/project/pytest-isolate/ Differential Revision: D84636534
dulinriley
force-pushed
the
export-D84636534
branch
from
24db257 to
f8251da
Compare
|
We won't be able to use this at the moment, or other plugins like pytest-forked, with GPU code: We'll either need to change that plugin to use "spawn" instead of "fork", or make our own plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The pytest-isolate package can support both pytest-timeout and pytest-forked,
to run each test in a separate process.
This should help prevent cross-contamination (one test affects a second test), as well
as preventing tests with fatal signals from taking down the whole test run.
Differential Revision: D84636534