Refactoring: move verify_casting out so it can be re-used by other tests #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 23, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Differential Revision: D83001963
pzhan9
force-pushed
the
export-D83001963
branch
from
f13068b to
c3a346c
Compare
Contributor
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 23, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Differential Revision: D83001963
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 25, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Differential Revision: D83001963
pzhan9
force-pushed
the
export-D83001963
branch
from
c3a346c to
9f5d249
Compare
Contributor
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 25, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Differential Revision: D83001963
pzhan9
force-pushed
the
export-D83001963
branch
from
9f5d249 to
da35533
Compare
Contributor
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 26, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Differential Revision: D83001963
pzhan9
force-pushed
the
export-D83001963
branch
from
da35533 to
418e449
Compare
Contributor
pzhan9
force-pushed
the
export-D83001963
branch
from
418e449 to
75da1b5
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 29, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Differential Revision: D83001963
Contributor
pzhan9
force-pushed
the
export-D83001963
branch
from
75da1b5 to
bb37ff6
Compare
Contributor
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 30, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Differential Revision: D83001963
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 30, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963
pzhan9
force-pushed
the
export-D83001963
branch
from
bb37ff6 to
113ce47
Compare
Contributor
pzhan9
force-pushed
the
export-D83001963
branch
from
113ce47 to
dd18172
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Sep 30, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963
Contributor
pzhan9
force-pushed
the
export-D83001963
branch
from
dd18172 to
5bae2e0
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Oct 1, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Oct 1, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Oct 1, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Oct 1, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963
pzhan9
force-pushed
the
export-D83001963
branch
from
5bae2e0 to
66d6c0c
Compare
Summary: We want to move sequence assignment to the client side, and actor Instance is a good place for that, since: 1. we can get it through `context::Actor`; 2. there is ongoing effort to deprecate `cap::CanSend` with `context::Actor`. so `context::Actor` will be accessible in client's message sending callsites. This diff: 1. adds a `struct Sequencer` which encapsulate the assignment logic. 2. adds a `fn seq_send` method to `ActorRef` show how it is used by the client. Reviewed By: mariusae Differential Revision: D82983004
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963
pzhan9
force-pushed
the
export-D83001963
branch
from
66d6c0c to
8216c54
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Oct 1, 2025
…sts (meta-pytorch#1303) Summary: Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963
Contributor
|
This pull request has been merged in a34a91e. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
…sts (meta-pytorch#1303) Summary: Pull Request resolved: meta-pytorch#1303 Two refactorings to make the next diff D82537988 looks less busy: 1. extract `cast_v0`; 2. extract `verify_casting`. Reviewed By: mariusae Differential Revision: D83001963 fbshipit-source-id: 33cb027b73e26d8b1606ff4eb5baa13454d2de6a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D83001963