Fix deeplift mypy error #1459
Closed
Fix deeplift mypy error #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
vivekmig
force-pushed
the
export-D67538043
branch
from
79e898e to
b14b423
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
vivekmig
force-pushed
the
export-D67538043
branch
from
b14b423 to
dd3fa2b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
vivekmig
force-pushed
the
export-D67538043
branch
from
dd3fa2b to
85b769d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Dec 22, 2024
Summary: Currently, Captum OSS tests are failing due to mypy failures (likely from new version) in DeepLift test cases. Adds fix for type failure caused by different signature between DeepLift and DeepLiftShap. Differential Revision: D67538043
vivekmig
force-pushed
the
export-D67538043
branch
from
85b769d to
aaacdca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
vivekmig
force-pushed
the
export-D67538043
branch
from
aaacdca to
9071a94
Compare
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Dec 23, 2024
Summary: Currently, Captum OSS tests are failing due to mypy failures (likely from new version) in DeepLift test cases. Adds fix for type failure caused by different signature between DeepLift and DeepLiftShap. Differential Revision: D67538043
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
vivekmig
force-pushed
the
export-D67538043
branch
from
9071a94 to
4b7f012
Compare
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Dec 23, 2024
Summary: Currently, Captum OSS tests are failing due to mypy failures (likely from new version) in DeepLift test cases. Adds fix for type failure caused by different signature between DeepLift and DeepLiftShap. Differential Revision: D67538043
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
vivekmig
pushed a commit
to vivekmig/captum-1
that referenced
this pull request
Dec 23, 2024
Summary: Currently, Captum OSS tests are failing due to mypy failures (likely from new version) in DeepLift test cases. Adds fix for type failure caused by different signature between DeepLift and DeepLiftShap. Differential Revision: D67538043
vivekmig
force-pushed
the
export-D67538043
branch
from
4b7f012 to
a67ac41
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
added 2 commits
December 23, 2024 14:05
Summary: Python 3.8 has reached EOL in Oct 2024, so we can upgrade minimum python required for Captum to 3.9. We are seeing test failures due to dependencies when running with Python 3.8, so upgrading minimum version to resolve these. Differential Revision: D67545940
Summary: Currently, Captum OSS tests are failing due to mypy failures (likely from new version) in DeepLift test cases. Adds fix for type failure caused by different signature between DeepLift and DeepLiftShap. Differential Revision: D67538043
vivekmig
force-pushed
the
export-D67538043
branch
from
a67ac41 to
afd0583
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67538043 |
|
This pull request has been merged in 9a7ef2e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently, Captum OSS tests are failing due to mypy failures (likely from new version) in DeepLift test cases. Adds fix for type failure caused by different signature between DeepLift and DeepLiftShap.
Differential Revision: D67538043