Improving typing of additional_forward_args
#1425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D65178564 |
Summary: Pull Request resolved: meta-pytorch#1425 Change `additional_forward_args` to resolve pyre errors and address the feedback on D64998803. Reviewed By: cyrjano Differential Revision: D65178564
|
This pull request was exported from Phabricator. Differential Revision: D65178564 |
craymichael
force-pushed
the
export-D65178564
branch
from
d2bb7ed to
514c1a5
Compare
|
This pull request has been merged in f3496d9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Change
additional_forward_argsto resolve pyre errors and address the feedback on D64998803.Differential Revision: D65178564