Address instances of "Overloaded function signature x will never be matched" + minor typing fixes #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64517613 |
craymichael
force-pushed
the
export-D64517613
branch
from
2a9391a to
ad31cdd
Compare
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 17, 2024
…atched" + minor typing fixes (meta-pytorch#1381) Summary: Many overloads produced false positives or required changing order due to mypy breaking ties by picking the first matching variant (https://mypy.readthedocs.io/en/stable/more_types.html). This fixes or suppresses these errors. Created T204932142 to address Literal-related issues. Reviewed By: vivekmig Differential Revision: D64517613
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64517613 |
…atched" + minor typing fixes (meta-pytorch#1381) Summary: Many overloads produced false positives or required changing order due to mypy breaking ties by picking the first matching variant (https://mypy.readthedocs.io/en/stable/more_types.html). This fixes or suppresses these errors. Created T204932142 to address Literal-related issues. Reviewed By: vivekmig Differential Revision: D64517613
craymichael
force-pushed
the
export-D64517613
branch
from
ad31cdd to
7f2e573
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64517613 |
Contributor
|
This pull request has been merged in 103a3fd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Many overloads produced false positives or required changing order due to mypy breaking ties by picking the first matching variant (https://mypy.readthedocs.io/en/stable/more_types.html). This fixes or suppresses these errors. Created T204932142 to address Literal-related issues.
Differential Revision: D64517613