Reducing pyre-fixme's in visualization.py #1377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D64405790 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Summary: This diff helps address the number of pyre-fixme's and return type annotation pyre errors in the visualizations.py file Differential Revision: D64405790
facebook-github-bot
force-pushed
the
export-D64405790
branch
from
925bd27 to
99c5325
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64405790 |
Summary: This diff addresses the C901 in visualization.py by breaking down the method Reviewed By: craymichael Differential Revision: D64404009
Summary: This diff helps address the number of pyre-fixme's and return type annotation pyre errors in the visualizations.py file Differential Revision: D64405790
facebook-github-bot
force-pushed
the
export-D64405790
branch
from
99c5325 to
031e1e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64405790 |
|
This pull request has been merged in 1994c23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff helps address the number of pyre-fixme's and return type annotation pyre errors in the visualizations.py file
Differential Revision: D64405790