Fix incompatible type breaking OSS tests #1371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64412835 |
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Correct typing in dataloader attr to prevent tests from breaking Differential Revision: D64412835
craymichael
force-pushed
the
export-D64412835
branch
from
f193598 to
ac62dc5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64412835 |
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Correct typing in dataloader attr to prevent tests from breaking Differential Revision: D64412835
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Correct typing in dataloader attr to prevent tests from breaking Differential Revision: D64412835
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Differential Revision: D64412835
craymichael
force-pushed
the
export-D64412835
branch
from
ac62dc5 to
57987f0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64412835 |
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Reviewed By: vivekmig Differential Revision: D64412835
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Reviewed By: vivekmig Differential Revision: D64412835
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Reviewed By: vivekmig Differential Revision: D64412835
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Reviewed By: vivekmig Differential Revision: D64412835
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Reviewed By: vivekmig Differential Revision: D64412835
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Reviewed By: vivekmig Differential Revision: D64412835
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Reviewed By: vivekmig Differential Revision: D64412835
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Oct 15, 2024
Summary: Fix or ignore all new type checks due to the release of mypy 1.12.0 Reviewed By: vivekmig Differential Revision: D64412835
Contributor
|
This pull request has been merged in c68334b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Correct typing in dataloader attr to prevent tests from breaking
Differential Revision: D64412835