stop stripping first character from output string #1351
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775617 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775617 |
csauper
added a commit
to csauper/captum
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: meta-pytorch#1351 previously first character was stripped as SOS token, but that doesn't actually seem to be the case with current LLMs. Keep all tokens. Differential Revision: D62775617
csauper
force-pushed
the
export-D62775617
branch
from
259e5f7 to
3c7b7e3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775617 |
csauper
force-pushed
the
export-D62775617
branch
from
3c7b7e3 to
36a3549
Compare
csauper
added a commit
to csauper/captum
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: meta-pytorch#1351 previously first character was stripped as SOS token, but that doesn't actually seem to be the case with current LLMs. Keep all tokens. Differential Revision: D62775617
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775617 |
csauper
added a commit
to csauper/captum
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: meta-pytorch#1351 previously first character was stripped as SOS token, but that doesn't actually seem to be the case with current LLMs. Keep all tokens. Differential Revision: D62775617
csauper
force-pushed
the
export-D62775617
branch
from
36a3549 to
0f5d929
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775617 |
csauper
added a commit
to csauper/captum
that referenced
this pull request
Sep 18, 2024
Summary: Pull Request resolved: meta-pytorch#1351 previously first character was stripped as SOS token, but that doesn't actually seem to be the case with current LLMs. Keep all tokens. Differential Revision: D62775617
csauper
force-pushed
the
export-D62775617
branch
from
0f5d929 to
3db2465
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775617 |
csauper
added a commit
to csauper/captum
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: meta-pytorch#1351 previously first character was stripped as SOS token, but that doesn't actually seem to be the case with current LLMs. Keep all tokens. Differential Revision: D62775617
csauper
force-pushed
the
export-D62775617
branch
from
3db2465 to
80f7b30
Compare
Summary: Pull Request resolved: meta-pytorch#1351 previously first character was stripped as SOS token, but that doesn't actually seem to be the case with current LLMs. Keep all tokens. Differential Revision: D62775617
csauper
force-pushed
the
export-D62775617
branch
from
80f7b30 to
e8fd40b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775617 |
Contributor
|
This pull request has been merged in 7b80c5b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: previously first character was stripped as SOS token, but that doesn't actually seem to be the case with current LLMs. Keep all tokens.
Differential Revision: D62775617