Future Async support for more test coverage #1317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D60118869 |
|
This pull request was exported from Phabricator. Differential Revision: D60118869 |
jjuncho
added a commit
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: #1317 Since Futures async is available for Feature Attributor, this diff expands the test cases that support/use FeatureAblation to cover all existing test cases in the diff. Reviewed By: cyrjano Differential Revision: D60118869
jjuncho
force-pushed
the
export-D60118869
branch
from
687d7d6 to
1892c89
Compare
facebook-github-bot
force-pushed
the
export-D60118869
branch
from
1892c89 to
176f99a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
Summary: Since Futures async is available for Feature Attributor, this diff expands the test cases that support/use FeatureAblation to cover all existing test cases in the diff. Reviewed By: cyrjano Differential Revision: D60118869
|
This pull request was exported from Phabricator. Differential Revision: D60118869 |
Summary: Since Futures async is available for Feature Attributor, this diff expands the test cases that support/use FeatureAblation to cover all existing test cases in the diff. Reviewed By: cyrjano Differential Revision: D60118869
facebook-github-bot
force-pushed
the
export-D60118869
branch
from
176f99a to
d55c09f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60118869 |
|
This pull request has been merged in 2434cf7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Since Futures async is available for Feature Attributor, this diff expands the test cases that support/use FeatureAblation to cover all existing test cases in the diff.
Reviewed By: cyrjano
Differential Revision: D60118869