Specify Types to enable future function splits #1253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55169019 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 21, 2024
Summary: As titled. There are many type error with method spliction due to vague types. Add type annotation as first step. Differential Revision: D55169019
cicichen01
force-pushed
the
export-D55169019
branch
from
100d425 to
983dfad
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55169019 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 21, 2024
Summary: As titled. There are many type error with method spliction due to vague types. Add type annotation for model defintions as first step. Differential Revision: D55169019
cicichen01
force-pushed
the
export-D55169019
branch
from
983dfad to
87212de
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55169019 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 21, 2024
Summary: As titled. There are many type error with method spliction due to vague types. Add type annotation for model defintions as first step. Differential Revision: D55169019
cicichen01
force-pushed
the
export-D55169019
branch
from
87212de to
f4e5069
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55169019 |
Summary: As titled. There are many type error with method split due to vague types. Add type annotation as first step. Differential Revision: D55169019
cicichen01
force-pushed
the
export-D55169019
branch
from
f4e5069 to
02954b3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55169019 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 21, 2024
Summary: As titled. There are many type error with method split due to vague types. Add type annotation as first step. Differential Revision: D55169019
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. There are many type error with method split due to vague types. Add type annotation as first step. Reviewed By: yucu Differential Revision: D55169019
Contributor
|
This pull request has been merged in 6e05bba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. There are many type error with method spliction due to vague types. Add type annotation as first step.
Differential Revision: D55169019