-
-
Notifications
You must be signed in to change notification settings - Fork 363
Set socket timeout to 5s #3929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set socket timeout to 5s #3929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
b9aac32 to
81fbd9d
Compare
500ms socket timeout is incredibly low
81fbd9d to
44f5b18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Signed-off-by: James Rich <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
=====================================
Coverage 0.52% 0.52%
=====================================
Files 394 394
Lines 23136 23136
Branches 2933 2933
=====================================
Hits 122 122
Misses 22993 22993
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
@weebl2000 i went ahead and fixed those detekt complaints, it looked like they had been previously suppressed/baselined (were not introduced by your changes, just were being hidden). For future contributions please ensure that the code passes |
Will keep it in mind 👌🏽 |
500ms socket timeout is incredibly low, 5 seconds makes more sense. Kept the total timeout the same.