Skip to content

feat: update frontend training contents #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Feb 17, 2025
Merged

feat: update frontend training contents #247

merged 23 commits into from
Feb 17, 2025

Conversation

YadaYuki
Copy link
Collaborator

@YadaYuki YadaYuki commented Feb 8, 2025

What

  • Migration create-react-app -> Vite-based SPA
  • Not changed main UI & Logic, just did some refactoring:
    • Integrate Linter & Formatter
    • Applied Lint & Format for all files 🙏🏻
    • Codebase organization ( migrated data fetching related logic to src/api/index.ts)
  • Minor changed trainign materials
  • Confirmed to work with [email protected], [email protected], and [email protected]

Why

CHECKS ⚠️

Please make sure you are aware of the following.

  • **The changes in this PR doesn't have private information

@YadaYuki YadaYuki changed the title feat: update frontend feat: update frontend training contents Feb 9, 2025
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added vscode recommended settings & extensions

"last 1 firefox version",
"last 1 safari version"
]
"devDependencies": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These deps are only for development, so migrated to devDeps

@@ -1,77 +1,78 @@
# STEP7: Implement a simple Mercari webapp as frontend


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated training materials 🙏🏻

Copy link
Contributor

@task4233 task4233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM except for some imo/nits left comments.

@YadaYuki YadaYuki requested a review from task4233 February 16, 2025 09:21
Copy link
Contributor

@task4233 task4233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
As I'm not super familiar with frontend code, I think it's better get review by the front end member as well.

Copy link
Collaborator

@azrsh azrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつか nit コメントしましたが基本良さそう
(nit コメントは対応しなくても問題ないです)

@YadaYuki YadaYuki requested review from xu-jiach and uki-a February 17, 2025 08:49
@YadaYuki YadaYuki requested a review from xu-jiach February 17, 2025 08:59
@YadaYuki YadaYuki merged commit 4dc16c6 into main Feb 17, 2025
1 check passed
@YadaYuki YadaYuki deleted the feat/update-frontend branch February 17, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants