-
Notifications
You must be signed in to change notification settings - Fork 306
feat: update frontend training contents #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…kage dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added vscode recommended settings & extensions
"last 1 firefox version", | ||
"last 1 safari version" | ||
] | ||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These deps are only for development, so migrated to devDeps
@@ -1,77 +1,78 @@ | |||
# STEP7: Implement a simple Mercari webapp as frontend | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated training materials 🙏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM except for some imo/nits left comments.
…s in ItemList component
…tend documentation
…ontend documentation
…sh and Japanese documentation
…ese documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As I'm not super familiar with frontend code, I think it's better get review by the front end member as well.
Co-authored-by: Ayumi Uki <[email protected]>
Co-authored-by: Ayumi Uki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いくつか nit コメントしましたが基本良さそう
(nit コメントは対応しなくても問題ないです)
…React.FC type annotation
What
src/api/index.ts
)[email protected]
,[email protected]
, and[email protected]
Why
→ In Build training course, we decided to use Vite-based Simple SPA
CHECKS⚠️
Please make sure you are aware of the following.