Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

feat: sqlite database implementation #1336

Merged
merged 21 commits into from
Sep 27, 2024
Merged

feat: sqlite database implementation #1336

merged 21 commits into from
Sep 27, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 26, 2024

Describe Your Changes

Use sqlite database to replace model.list

  • Library: SQLiteCpp
  • Keep the data structure the same as model.list
    • model_id: Unique identifier for the model
    • author_repo_id: Author or repository identifier
    • branch_name: Branch name in the repository
    • path_to_model_yaml: Path to the model's YAML file
    • model_alias: Shortened alias for the model
  • Use cpp:result for return value

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev changed the title feat: sqlite feat: sqlite database implementation Sep 26, 2024
@vansangpfiev vansangpfiev marked this pull request as ready for review September 26, 2024 05:42
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ looks good to me. Great work!

@vansangpfiev vansangpfiev merged commit 08b8841 into dev Sep 27, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the feat/sqlite branch September 27, 2024 01:09
@dan-menlo
Copy link
Contributor

@gabrielle-ong We will need to account for this in the QA checklist - i.e. ensuring that model list etc is persisted correctly in sqlite

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epic: SQLite database implementation
4 participants