Revert "Fix Js.String.match_ return type" because it's a breaking change with ReScript #319
Conversation
jfrolich
force-pushed
the
revert-breaking-change
branch
from
359d9ca to
f5cb19b
Compare
This reverts commit ccceb69.
|
Why is this breaking ReScript compatibility? I cherry picked the commit from rescript-lang/rescript#5070 |
|
I think what @jfrolich means is that it might become hard to track which upstream breaking changes have made it into Melange. This change in particular did not make it until ReScript v10: rescript-lang/rescript-lang.org#552. I suggest that we start versioning Melange (maybe also publishing in opam), so that we can map Melange versions with ReScript versions somehow, e.g.
That way, Melange users have an easier way of tracking which breaking changes made it to the codebase, and which ReScript libraries might be supported for each version of Melange. If the above makes sense, then we could:
@anmonteiro what do you think? |
|
Exactly! For this particular change it's water under the bridge (we will be at rescript 10 soon). But for future breaking changes having this system would be amazing! |
|
Makes sense to do that. I'll try keeping those notes next time I batch a few cherry picked commits. |
I think it's a good change in general, but I think we should be careful about breaking with ReScript, as it makes parallel use of both compilers impossible. Which is something companies/projects want to do to support both compilers when experimenting with melange. I would suggest when making these changes to the bindings to create a new function instead of changing the old one breaking compatibility.
This reverts commit ccceb69.