Skip to content

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Jul 6, 2021

Closes #169

What's inside ?

  • Addition of margin-right to the searchbox
  • Addition of a menu in the playground to see the changes and impact

Screenshots

Before:
before

After:
after

@mdubus mdubus added the bug Something isn't working label Jul 6, 2021
@mdubus mdubus requested a review from bidoubiwa July 6, 2021 13:45
@bidoubiwa
Copy link
Contributor

Based on vuepress default search box, there is margin applied to mobile size, is this always applied or should we apply it?
https://github.com/vuejs/vuepress/blob/master/packages/%40vuepress/plugin-search/SearchBox.vue

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥🔥🔥

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 7, 2021

Build succeeded:

@bors bors bot merged commit ae9c4c5 into main Jul 7, 2021
@bors bors bot deleted the add_margin_right branch July 7, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misaligned search box after upgrade to version 0.11
2 participants