Add layout option and style #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
requested changes
Jun 1, 2021
Co-authored-by: Clémentine Urquizar <[email protected]>
|
bors merge |
bidoubiwa
approved these changes
Jun 2, 2021
bors bot
added a commit
that referenced
this pull request
Jun 2, 2021
146: Add layout option and style r=bidoubiwa a=mdubus ## What's wrong ? **Problem 1:** [docs-searchbar](https://github.com/meilisearch/docs-searchbar.js) provides an option to choose between 2 layouts : "simple" and "columns". But the plugin `vuepress-plugin-meilisearch` doesn't provide access to this existing option. **Problem 2:** After making this option available, the design looks horrific:  ## What's inside this PR This PR makes the `layout` option available. It also adapts the style to match the existing one in docs-searchbar. Style in `docs-searchbar` (simple layout):  Style in `vuepress-plugin-meilisearch` after this PR (simple layout):  ## How to test Go to the file `playground/.vuepress/config.js` and add `"layout": "simple"` in the options:  Note that you might need to restart your server. Please make sure to test that it doesn't break the "columns" layout 🙏 Co-authored-by: Morgane Dubus <[email protected]> Co-authored-by: Morgane Dubus <[email protected]>
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 2, 2021
146: Add layout option and style r=bidoubiwa a=mdubus ## What's wrong ? **Problem 1:** [docs-searchbar](https://github.com/meilisearch/docs-searchbar.js) provides an option to choose between 2 layouts : "simple" and "columns". But the plugin `vuepress-plugin-meilisearch` doesn't provide access to this existing option. **Problem 2:** After making this option available, the design looks horrific:  ## What's inside this PR This PR makes the `layout` option available. It also adapts the style to match the existing one in docs-searchbar. Style in `docs-searchbar` (simple layout):  Style in `vuepress-plugin-meilisearch` after this PR (simple layout):  ## How to test Go to the file `playground/.vuepress/config.js` and add `"layout": "simple"` in the options:  Note that you might need to restart your server. Please make sure to test that it doesn't break the "columns" layout 🙏 Co-authored-by: Morgane Dubus <[email protected]> Co-authored-by: Morgane Dubus <[email protected]>
curquiza
approved these changes
Jun 2, 2021
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's wrong ?
Problem 1:
docs-searchbar provides an option to choose between 2 layouts : "simple" and "columns".
But the plugin
vuepress-plugin-meilisearchdoesn't provide access to this existing option.Problem 2:
After making this option available, the design looks horrific:
What's inside this PR
This PR makes the
layoutoption available.It also adapts the style to match the existing one in docs-searchbar.
Style in
docs-searchbar(simple layout):Style in
vuepress-plugin-meilisearchafter this PR (simple layout):How to test
Go to the file
playground/.vuepress/config.jsand add"layout": "simple"in the options:Note that you might need to restart your server.
Please make sure to test that it doesn't break the "columns" layout 🙏