Skip to content

Rename requestOptions to searchParams #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Apr 28, 2021
Merged

Rename requestOptions to searchParams #70

bors merged 2 commits into from
Apr 28, 2021

Conversation

@codedge
Copy link
Contributor

@codedge codedge commented Apr 24, 2021

This PR renames the requestOptions variable to searchParams, see #58.

@curquiza
Copy link
Member

curquiza commented Apr 27, 2021

Hello again @codedge!
Thanks for your PR, I would like to merge it, but I can't since there are git conflicts. Could you please update your branch and remove them?

Thanks again for your PR, I see you are really involved in this repo right now, this is really helpful!

@codedge
Copy link
Contributor Author

codedge commented Apr 27, 2021

Happy to help! Conflicts are resolved.

curquiza
curquiza reviewed Apr 27, 2021
View reviewed changes
curquiza
curquiza approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

bors merge

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Apr 28, 2021
@bors
Copy link
Contributor

bors bot commented Apr 28, 2021

Build succeeded:

@bors bors bot merged commit e67dc0e into meilisearch:main Apr 28, 2021
@codedge codedge mentioned this pull request Apr 30, 2021
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza approved these changes

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codedge @curquiza