Skip to content

MeilisearchManager::remove() may drop deletion tasks from earlier chunks #420

@coderabbitai

Description

@coderabbitai

Context

During review of PR #410, a potential issue was identified in the MeilisearchManager::remove() method where deletion tasks from earlier chunks may be lost when the same index appears in multiple chunks.

Problem

In src/Services/MeilisearchManager.php (lines 167-174), the current implementation collects Engine::remove($chunk) results into an array and then uses array_merge(...$responses). Since Engine::remove() returns an array keyed by index name, later chunk results will overwrite earlier ones for the same index key, potentially losing deletion tasks from earlier chunks.

References

Additional Notes

This issue tracks the follow-up work to address the deletion task aggregation logic.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions