Skip to content

with_distrinct_attribute accepts None #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2024
Merged

with_distrinct_attribute accepts None #576

merged 5 commits into from
Apr 21, 2024

Conversation

@NoodleSamaChan
Copy link
Contributor

@NoodleSamaChan NoodleSamaChan commented Apr 21, 2024

Pull Request

Related issue

Fixes #368

What does this PR do?

  • changed with_distinct_attribute so that it accepts None

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@irevoire irevoire self-requested a review April 21, 2024 14:29
@irevoire irevoire added the enhancement New feature or request label Apr 21, 2024
irevoire
irevoire suggested changes Apr 21, 2024
View reviewed changes
@irevoire irevoire added the breaking-change The related changes are breaking for the users label Apr 21, 2024
@NoodleSamaChan NoodleSamaChan requested a review from irevoire April 21, 2024 14:48
irevoire
irevoire approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Apr 21, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 043a553 into meilisearch:main Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@irevoire irevoire irevoire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change The related changes are breaking for the users enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

with_distrinct_attribute should accept None as a value.

2 participants

@NoodleSamaChan @irevoire