Feature/Analytics #254
Merged
Feature/Analytics #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Member
Author
|
@irevoire it seems to be breaking but the breaking comes from inside a dependency in the wasm-build 🤔 |
sanders41
reviewed
Apr 3, 2022
brunoocasali
force-pushed
the
feature/add-user-agent-header
branch
from
20d68f9 to
c57b5de
Compare
Contributor
|
I'll check the pr next week! |
Contributor
|
Since
|
irevoire
added a commit
that referenced
this pull request
May 5, 2022
Having a link to the web_app `lib.rs` in the examples was making it try to compile as a dev dependencies which is a constraint we don’t want. I removed it and instead included ALL the examples in our workspace which means we’re now using THEIR cargo.toml instead of ours and meilisearch-rust is compiled as a normal dependency for these examples. I also added a `cargo check` for all the examples / tests / code in the repo. This should execute faster than the test and thus throw errors faster. This should unlock #254
brunoocasali
force-pushed
the
feature/add-user-agent-header
branch
from
c57b5de to
b2d8773
Compare
bors bot
added a commit
that referenced
this pull request
May 5, 2022
286: Remove the wasm lib.rs from the manifest r=brunoocasali a=irevoire Having a link to the web_app `lib.rs` in the examples was making it try to compile as a dev dependencies which is a constraint we don’t want. I removed it and instead included ALL the examples in our workspace which means we’re now using THEIR cargo.toml instead of ours and meilisearch-rust is compiled as a normal dependency for these examples. I also added a `cargo check` for all the examples / tests / code in the repo. This should execute faster than the test and thus throw errors faster. This should unlock #254 Co-authored-by: Irevoire <[email protected]>
bors bot
added a commit
that referenced
this pull request
May 5, 2022
286: Remove the wasm lib.rs from the manifest r=brunoocasali a=irevoire Having a link to the web_app `lib.rs` in the examples was making it try to compile as a dev dependencies which is a constraint we don’t want. I removed it and instead included ALL the examples in our workspace which means we’re now using THEIR cargo.toml instead of ours and meilisearch-rust is compiled as a normal dependency for these examples. I also added a `cargo check` for all the examples / tests / code in the repo. This should execute faster than the test and thus throw errors faster. This should unlock #254 Co-authored-by: Irevoire <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
brunoocasali
pushed a commit
that referenced
this pull request
May 5, 2022
Having a link to the web_app `lib.rs` in the examples was making it try to compile as a dev dependencies which is a constraint we don’t want. I removed it and instead included ALL the examples in our workspace which means we’re now using THEIR cargo.toml instead of ours and meilisearch-rust is compiled as a normal dependency for these examples. I also added a `cargo check` for all the examples / tests / code in the repo. This should execute faster than the test and thus throw errors faster. This should unlock #254
bors bot
added a commit
that referenced
this pull request
May 5, 2022
286: Remove the wasm lib.rs from the manifest r=brunoocasali a=irevoire Having a link to the web_app `lib.rs` in the examples was making it try to compile as a dev dependencies which is a constraint we don’t want. I removed it and instead included ALL the examples in our workspace which means we’re now using THEIR cargo.toml instead of ours and meilisearch-rust is compiled as a normal dependency for these examples. I also added a `cargo check` for all the examples / tests / code in the repo. This should execute faster than the test and thus throw errors faster. This should unlock #254 Co-authored-by: Irevoire <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
bors bot
added a commit
that referenced
this pull request
May 5, 2022
286: Remove the wasm lib.rs from the manifest r=brunoocasali a=irevoire Having a link to the web_app `lib.rs` in the examples was making it try to compile as a dev dependencies which is a constraint we don’t want. I removed it and instead included ALL the examples in our workspace which means we’re now using THEIR cargo.toml instead of ours and meilisearch-rust is compiled as a normal dependency for these examples. I also added a `cargo check` for all the examples / tests / code in the repo. This should execute faster than the test and thus throw errors faster. This should unlock #254 Co-authored-by: Irevoire <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
Member
Author
|
bors merge |
bors bot
added a commit
that referenced
this pull request
May 5, 2022
254: Feature/Analytics r=brunoocasali a=brunoocasali - Add `User-Agent` inside the pre-defined headers. Add Rust support as requested here meilisearch/integration-guides#150 Co-authored-by: Bruno Casali <[email protected]>
Contributor
|
Build failed: |
irevoire
suggested changes
May 5, 2022
Co-authored-by: Tamo <[email protected]>
Member
Author
|
bors merge |
Contributor
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
May 9, 2022
287: Update version for the next release (v0.17.0) r=curquiza a=brunoocasali This version makes this package compatible with Meilisearch v0.27.0 🎉 Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information on the changes. ##⚠️ Breaking changes * Remove jsonindex (#278) `@abhizer` ## 🚀 Enhancements * Add cli-app example to meilisearch-rust (#279) `@salugi` * Ensure nested field support (#273) `@bidoubiwa` * Add new search parameters `highlightPreTag`, `highlightPostTag` and `cropMarker` (#274) `@bidoubiwa` * Add User-Agent header to have analytics in every HTTP request (#254) `@brunoocasali` Analytics is enabled by default in the server, but you can disable them by following [this guide](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html#how-to-disable-data-collection) Also, of course, every analytics data we collect are **ANONYMOUS** [read the guide for more information](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html). Thanks again to `@abhizer,` `@bidoubiwa,` `@irevoire,` `@salugi` and a1! 🎉 Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Agentinside the pre-defined headers.Add Rust support as requested here meilisearch/integration-guides#150