Support custom agents #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2022
brunoocasali
changed the title
bidoubiwa
reviewed
Aug 1, 2022
| expect(index.options).to eq(options.merge({ convert_body?: true })) | ||
|
|
||
| expect(MeiliSearch::Index).to receive(:get).with( | ||
| "#{URL}/indexes/options", |
Contributor
There was a problem hiding this comment.
A bit confusing to call the index options, it looks like a route name and not a resource indexes/options.
But a part for that the test is good!
Member
Author
There was a problem hiding this comment.
Agreed, I'll generate an issue to handle that plus a way to randomize the indexes names as we do in the rails :)
Member
Author
|
bors merge |
Contributor
bors bot
added a commit
to meilisearch/meilisearch-rails
that referenced
this pull request
Aug 1, 2022
179: Feature/Analytics r=brunoocasali a=brunoocasali Merge after meilisearch/meilisearch-ruby#354 With both PRs, we can send a custom header with the name of this gem according to meilisearch/integration-guides#150. Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to meilisearch/integration-guides#150 take #2
We will use this door to send information from the Rails gem.