Update README #1248
Merged
Update README #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think most of the changes are automatically updatable with our script! Maybe all of them 😇 |
mdubus
reviewed
Jun 1, 2022
brunoocasali
reviewed
Jun 2, 2022
bidoubiwa
suggested changes
Jun 2, 2022
Co-authored-by: cvermand <[email protected]>
Co-authored-by: cvermand <[email protected]>
guimachiavelli
commented
Jun 14, 2022
bidoubiwa
suggested changes
Aug 2, 2022
Contributor
bidoubiwa
left a comment
bidoubiwa
left a comment
There was a problem hiding this comment.
all the client.index.something should be replaced with
client.index('myIndex').something. You can name the index something else if you prefer
guimachiavelli
commented
Aug 2, 2022
Member
Author
guimachiavelli
left a comment
guimachiavelli
left a comment
There was a problem hiding this comment.
Thanks for the suggestions, @bidoubiwa—all accepted.
Co-authored-by: cvermand <[email protected]>
bidoubiwa
suggested changes
Aug 2, 2022
Co-authored-by: cvermand <[email protected]>
Co-authored-by: cvermand <[email protected]>
bidoubiwa
added
the
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in the @meilisearch/docs-team's full review of the SDK READMEs.
We have focused on improving text clarity and other minor changes. These are of course only suggestions, so please let us know what you think (and whether you want to push back on anything).