-
Notifications
You must be signed in to change notification settings - Fork 32
Feature/Analytics #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Analytics #129
Conversation
|
Dart doesn’t support this kind of feature yet dart-lang/sdk#18769 |
Upgrade CONTRIBUTING and check-release script in order to prevent new releases coming out without upgrading all the places with new version
14608ee to
65a882e
Compare
| echo "$file2: found $file_tag2 - expected $current_tag" | ||
| echo "$file3: found $file_tag3 - expected $current_tag" | ||
| echo "$file4: found $file_tag4 - expected $round_current_tag" | ||
| echo "$file4: found $file_tag4 - expected $current_tag" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't found the definition of the$round_current_tag so I replaced with $current_tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was mistake, well spotted
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well done! 💪
|
bors merge |
|
Build succeeded: |
Versionclass to easily access package version data.Version.qualifiedVersionto headersAfter the implementation the MeiliSearch server is outputting the expected 💯
[2022-01-19T18:33:47Z INFO actix_web::middleware::logger] 172.17.0.1:57704 "GET /keys HTTP/1.1" 200 14 "-" "MeiliSearch Dart (v0.5.0)" 0.000118DISCLAIMER: I've tried other ways to collect these data eg.
Add dart support as requested here meilisearch/integration-guides#150