Add fieldsToIndex as option in backfill script #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2022
bidoubiwa
changed the title
alallema
reviewed
Oct 25, 2022
functions/src/import/index.ts
Outdated
| @@ -94,14 +98,15 @@ async function retrieveCollectionFromFirestore( | |||
| * Adapts documents and indexes them in Meilisearch. | |||
| * @param {any} docs | |||
There was a problem hiding this comment.
Why we use any instead of DocumentSnapshot[] here?
There was a problem hiding this comment.
I thought the previous one was a mistake @param {Change<DocumentSnapshot>} change since change is not docs. But you'r right, putting it back :)
| const document = adaptDocument( | ||
| documentId, | ||
| after, | ||
| config.meilisearch.fieldsToIndex || '' |
There was a problem hiding this comment.
Same about:
fieldsToIndex: process.env.MEILISEARCH_FIELDS_TO_INDEX || '',Is it not the same parameter?
There was a problem hiding this comment.
because the type of MeilisearchConfig specifies that it can be an undefined
export type MeilisearchConfig = {
host: string
apiKey: string
indexUid: string
fieldsToIndex?: string
}And typescript does not infer that the variable was already set to string in config so it raises an error
Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
functions/src/import/config.ts
Outdated
| @@ -48,6 +48,7 @@ program | |||
| '-a, --api-key <api-key>', | |||
| 'The Meilisearch API key with permission to perform actions on indexes. Both the private key and the master key are valid choices but we strongly recommend using the private key for security purposes.' | |||
| ) | |||
| .option('-f, --fields-to-index <fields-to-index>', 'test') | |||
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #134
The
fieldsToIndexoption was missing in the backfill script.Example now: