Skip to content

Conversation

@maryamsulemani97
Copy link
Contributor

closes #1727

@maryamsulemani97 maryamsulemani97 added this to the v0.28 milestone Jun 16, 2022
@maryamsulemani97 maryamsulemani97 linked an issue Jun 16, 2022 that may be closed by this pull request
@dichotommy
Copy link
Contributor

I was indeed wrong! I offer my deepest apologies 🙇🏻

See #1742 for an explanation of why v0.28 without the patch version is good, and actually better than v0.28.0.

maryamsulemani97 and others added 2 commits June 20, 2022 11:02
Co-authored-by: Clémentine Urquizar - curqui <[email protected]>
Co-authored-by: Tommy <[email protected]>
Co-authored-by: Clémentine Urquizar - curqui <[email protected]>
Co-authored-by: Clémentine Urquizar - curqui <[email protected]>
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now that all @curquiza's suggestions have been integrated 🥍

@maryamsulemani97
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 29, 2022

Build succeeded:

@bors bors bot merged commit a68eaf9 into v0.28 Jun 29, 2022
@bors bors bot deleted the Update-Docker-and-Source-tags branch June 29, 2022 10:27
@guimachiavelli guimachiavelli mentioned this pull request Jun 30, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Docker and Source tags

4 participants