Skip to content

[IMP] Import/Export Bookmarks #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

[IMP] Import/Export Bookmarks #197

merged 1 commit into from
Jun 4, 2024

Conversation

@user-64bit
Copy link
Contributor

@user-64bit user-64bit commented May 5, 2024

This commit adds functionality of importing/exporting your personal bookmarks. It can help to share your bookmarks with your friends/family or get their bookmarks too.

issue: #156

@user-64bit
Copy link
Contributor Author

user-64bit commented May 5, 2024

Hello @medyo
As I'm no good in TS types and .css things. If there is any changes you need.
Please Inform me. 🙂

@medyo medyo self-requested a review May 8, 2024 16:48
medyo
medyo requested changes May 8, 2024
View reviewed changes
@medyo
Copy link
Owner

medyo commented May 8, 2024

Hello @medyo As I'm no good in TS types and .css things. If there is any changes you need. Please Inform me. 🙂

for the UI, I'll review it later, let's finish the logic first

@user-64bit
Copy link
Contributor Author

user-64bit commented May 16, 2024

Hey @medyo 👋
Apologies for late response. 😓 (got busy with work)
I've changed things as per your suggestion.
Please have a look and tell me if there is any change you need.
Thanks 🙂

medyo
medyo requested changes May 22, 2024
View reviewed changes
@user-64bit
Copy link
Contributor Author

user-64bit commented May 23, 2024

Hey there @medyo 👋
I've done the changes as per your suggestion.
You can have a look.
Thanks 🙂

@medyo
Copy link
Owner

medyo commented May 24, 2024

Great, can you also add a feedback toast when the boomarks are exported or imported. something like
toast('Your bookmarks have been successfully exported', { theme: 'defaultToast' })

@medyo medyo added the New feature Request a new language to add label May 24, 2024
@user-64bit
Copy link
Contributor Author

user-64bit commented May 25, 2024

@medyo
Added toast as per your suggestion. 🙂

medyo
medyo requested changes May 27, 2024
View reviewed changes
@user-64bit
[IMP] Import/Export Bookmarks
8b06ee3 
This commit adds functionality of importing/exporting your personal bookmarks.
It can help to share your bookmarks with your friends or get their bookmarks too.
@user-64bit
Copy link
Contributor Author

user-64bit commented May 30, 2024

@medyo 👋
I've made the changes as per requested.
Thanks 🙂

@medyo medyo changed the base branch from master to develop June 4, 2024 20:12
@medyo medyo merged commit 61b17e5 into medyo:develop Jun 4, 2024
@medyo
Copy link
Owner

medyo commented Jun 4, 2024

I just merged your contribution
Thanks a lot @us3r64bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyo medyo medyo requested changes

Assignees

@user-64bit user-64bit

Labels

New feature Request a new language to add

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@user-64bit @medyo