Skip to content

Conversation

@nuzzio
Copy link
Contributor

@nuzzio nuzzio commented Feb 22, 2014

The existing reference was causing the following scenario, on first load, in both html5 and flash:

  1. Load page with player (http://mediaelementjs.com).
  2. On the bottom control bar, press the "Play" button, allow the movie playhead to advance, note the time.
  3. On the bottom control bar, press the "Pause" button.
  4. Click on the big play button or the overlay that contains it.
  5. The player will reload the video and play it from 0. In Flash in IE8 it will reset to 0 and not play.

After the fix, it works as expected in html5, Flash and Flash IE8.

@johndyer
Copy link
Collaborator

Thanks so much for this. Can't believe this mistake has been here so long!

johndyer added a commit that referenced this pull request Mar 27, 2014
Fixed the reference to `media` in the bigPlay control creation.
@johndyer johndyer merged commit 9bdab69 into mediaelement:master Mar 27, 2014
@nuzzio
Copy link
Contributor Author

nuzzio commented Mar 27, 2014

Happy to help.

rexblack pushed a commit to rexblack/mediaelement that referenced this pull request May 22, 2014
Fixed the reference to `media` in the bigPlay control creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants