Skip to content

Conversation

viable-hartman
Copy link

@viable-hartman viable-hartman commented May 23, 2017

The mkdocs project loads extensions via a yaml file i.e. mkdocs.yml like so:

markdown_extensions:
  - qrcode:
      configs:
          intPixelSize: 4
          useShortSyntax: True

When loading the qrcode extension this way, configs could be left blank, so I've added a check for "configs".

When loading the qrcode extension this way, useShortSyntax is already a Boolean type, so I've added the code to verify this.

Finally, the configs options are loaded as key value pairs so ".items()" becomes necessary.

@mearns
Copy link
Owner

mearns commented May 23, 2017

I'm going to accept this, but this fork is generally unmaintained. I don't remember if I ever even made any changes relative to the parent repo, but I suggest you make a pull request to the original: airtonix/python-markdown-qrcode

@mearns mearns merged commit 414c829 into mearns:master May 23, 2017
@mearns
Copy link
Owner

mearns commented May 23, 2017

Eh, nevermind, looks like the original project is unmaintained, too. Sorry =(. Feel free to fork again if you have any intention on maintaining this. I'll spend a few minutes to see if I can at least get your changes pushed up to pypi.

@mearns
Copy link
Owner

mearns commented May 23, 2017

Sorry, looks like the package on pypi is own by the original author, so I don't think I have any way to update the package with your changes.

@viable-hartman
Copy link
Author

No problem, perhaps others will find this useful.

I did the pull request on your fork because the original doesn't work, (i.e. has the errors that you already fixed). Pulling in my pull request added the changes to your pull request on the original, so hopefully the author will just pull yours in at some point.

Maybe we could get him/her to allow one of us to maintain this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants