Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Conversation

@wmsbill
Copy link
Contributor

@wmsbill wmsbill commented Oct 25, 2018

This PR aims to add a new example for for await...of as a supporting example for the for await...of statement MDN docs page.

@wbamberg wbamberg requested a review from Elchi3 October 29, 2018 20:08
@schalkneethling
Copy link

@wmsbill Because of the following security vulnerability https://snyk.io/blog/malicious-code-found-in-npm-package-event-stream that was revealed yesterday, we are reaching out to everyone that currently has an open PR on interactive examples.

We ask that you please update your fork's master branch, and rebase your current feature branch against the new master. This will update the affected dependency to a version that is no longer affected, and remove the security concern.

We appreciate your assistance in this matter. Should you need any assistance, please feel free to reach out.

@wmsbill wmsbill force-pushed the for-await-of-example branch from 524822e to 801e9c3 Compare January 28, 2019 20:15
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very sorry this took forever. I'm finally cleaning my review queue.
I guess this could still land. const seems generally preferable, though.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 23a7a05 into mdn:main Jan 17, 2022
@welcome
Copy link

welcome bot commented Jan 17, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@wmsbill wmsbill deleted the for-await-of-example branch January 17, 2022 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants