Update nodejs data for URL
#24997
Merged
Update nodejs data for URL
#24997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
caugner
previously requested changes
Nov 12, 2024
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
Overall LGTM, just one issue:
github-actions
bot
added
the
data:browsers
github-actions
bot
added
the
merge conflicts 🚧
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
queengooborg
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the basic support of
URLis first added in v7.0.0, later added to v6.13.0URLclass implement is added in v7.0.0, via nodejs/node#7448, and backlogged to v6.13.0URL.prototype.toJSON()implement is added in v7.7.0, via nodejs/node#11236, and backlogged to v6.13.0the issue for
URL.prototype.searchParamswhich will return an empty list when init is got fixed in v7.3.0, via nodejs/node#9484, and backlogged to v6.13.0Test results and supporting details
https://nodejs.org/docs/latest/api/globals.html#url
https://nodejs.org/docs/latest/api/url.html#class-url
https://nodejs.org/en/blog/release/v6.13.0/
https://nodejs.org/en/blog/release/v7.0.0/
https://nodejs.org/en/blog/release/v10.0.0/
Related issues
see also nodejs/node#55806
see also #24998