Fixed Stream decode C0 byte (nil) processing error #68
Conversation
after C0 byte (nil) stream switched to "End of stream state", added test. Minor changes made in modules formatting to satisfy modules formatting rules checked in tests.
lib/streams.js
Outdated
| } | ||
|
|
||
| Base.prototype.emit.apply(this, arguments) | ||
| } |
There was a problem hiding this comment.
This is a very bad practice, and it will only work for on(‘data’) handlers and not piped streams.
…ility reasons.
When wrap is true decoded items are passed in form of {value: data} instead of data.
Using wrap=true for decoder stream allows decoding of C0 byte (nil).
test/streams.js
Outdated
|
|
||
| var pack = msgpack() | ||
| var decoder = pack.decoder() | ||
| decoder.wrap = true |
There was a problem hiding this comment.
can you pass this as an option instead?
|
Can you also add the same for the encoder? |
|
Sorry, to confirm for encoder. Using this option we can pass decoder output to encoder. |
|
The overall goal is to have source.pipe(encoder).pipe(decoder).pipe(sink) have the same input/output sata. I would keep the name of the option the same, but do what make sense to you. |
|
Sorry, don't understand how to get same input and output data in this scanario: For example when I pass null to encoder it will translate it to C0 byte, then Can you explain please? |
|
What I mean is that the encode takes objects in the form of |
When wrap = true decoder stream outputs {value:data} instead of data,
encoder stream encodes data extracted from {value:data}.
encoder/decoder streams chain with wrap options. Wrap option for encoder/decoder streams documented in readme.md
lib/streams.js
Outdated
| } | ||
|
|
||
| Base.call(this, opts) | ||
| this._unwrap = ('wrap' in opts) && opts.wrap |
There was a problem hiding this comment.
if the option is wrap, the property should be ._wrap.
README.md
Outdated
| Builds a stream in object mode that encodes msgpack. | ||
|
|
||
| Supported options: | ||
| wrap. |
There was a problem hiding this comment.
can you make this a list:
Supported options:
* `wrap`, put the text inline.
README.md
Outdated
| Builds a stream in object mode that decodes msgpack. | ||
|
|
||
| Supported options: | ||
| wrap. |
Minor changes in documentation for wrap option of encoder/decoder.
|
Can you please rebase? This now conflicts with master. |
Fixed Stream decode processing error:
after C0 byte (nil) stream switched to "End of stream state",
added test.
Minor changes made in modules formatting to satisfy modules
formatting rules checked in tests.