-
-
Notifications
You must be signed in to change notification settings - Fork 303
[Installer] Dynamic theme preview loading, Iframe previews, and other small improvements #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrblomblo
wants to merge
9
commits into
mcmonkeyprojects:master
Choose a base branch
from
mrblomblo:installer-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+130
−220
Open
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f17d2fa
Dynamic theme preview loading, Iframe previews, and other improvements
mrblomblo 3614d74
oops
mrblomblo e37f176
Fixes
mrblomblo 6619a86
Fix theme previews not being applied
mrblomblo e803b23
Use ViewData instead of GET for overriding theme in _Layout
mrblomblo 3229b3a
Add core parameters to preview
mrblomblo 484a073
Merge branch 'master' into pr/1036
mcmonkey4eva 54a5f85
Fixes
mrblomblo f2e56a7
Add noise image bg to core params
mrblomblo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| @page | ||
| @section Header { | ||
| <link rel="stylesheet" href="css/[email protected]" /> | ||
| <link rel="stylesheet" href="css/[email protected]" /> | ||
| } | ||
| <script> | ||
| (function () { | ||
| const urlParams = new URLSearchParams(window.location.search); | ||
| const themeId = urlParams.get('theme'); | ||
| if (themeId) { | ||
| const linkElement = document.createElement('link'); | ||
mrblomblo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| linkElement.rel = 'stylesheet'; | ||
| linkElement.href = `css/themes/${themeId}.css`; | ||
| document.head.appendChild(linkElement); | ||
| } | ||
| })(); | ||
| </script> | ||
|
|
||
| <div class="theme_preview-content"> | ||
| <div class="theme_preview-item"> | ||
| <p>Core Parameters will go here</p> | ||
| </div> | ||
|
|
||
| <hr> | ||
|
|
||
| <div class="theme_preview-item"> | ||
| <div class="alt-prompt-buttons-wrapper"> | ||
| <button class="alt-prompt-buttons alt-prompt-generate-button basic-button translate" id="alt_generate_button">Generate</button> | ||
| <button class="alt-prompt-buttons alt-prompt-center-button basic-button" id="alt_center_button">⮟</button> | ||
| <button class="alt-prompt-buttons interrupt-button interrupt-button-none alt-interrupt" id="alt_interrupt_button">×</button> | ||
| </div> | ||
| </div> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| html, body { | ||
| height: 100% | ||
mrblomblo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| #alt_generate_button { | ||
| margin-left: 0 !important; | ||
| } | ||
| .version-display { | ||
| display: none; | ||
| visibility: hidden; | ||
| } | ||
| .theme_preview-content { | ||
| height: 100%; | ||
| align-content: center; | ||
| margin-top: -0.25rem; | ||
| } | ||
| .theme_preview-item { | ||
| display: flex; | ||
| justify-content: center; | ||
| } | ||
| .theme_preview-item:not(:last-child) { | ||
| margin-bottom: 0.5em; | ||
| } | ||
| .theme_preview-item .theme_preview-text { | ||
| font-size: 1.25rem; | ||
| margin-bottom: 0; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.