Skip to content

Fix: for-in loop #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2016
Merged

Fix: for-in loop #3

merged 1 commit into from
Jun 16, 2016

Conversation

@mcmath
Copy link
Owner

@mcmath mcmath commented Jun 16, 2016

for...in loop should iterate over own properties only.

@mcmath
Fix: for...in loop
aa0d6ca 
`for...in` loop should iterate over own enumerable properties only.
@coveralls
Copy link

coveralls commented Jun 16, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling aa0d6ca on fix/for-in into 12aca80 on master.

@mcmath mcmath merged commit aa0d6ca into master Jun 16, 2016
mcmath added a commit that referenced this pull request Jun 16, 2016
@mcmath
Merge branch 'fix/for-in'
88d98a6 
Merges pull request #3
mcmath added a commit that referenced this pull request Jun 16, 2016
@mcmath
v1.1.2
54b0953 
This release fixes a `for...in` loop by ensuring it loops
over the object's own enumerable properties rather than
all enumerable properties.

#### Fix

- Fixes `for...in` loop by merging PR #3

#### Development

- Enforces the above fix through `tslint.json`
@mcmath mcmath deleted the fix/for-in branch June 16, 2016 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcmath @coveralls