Enable disabling target files for custom targets #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This MR adds a feature for users to disable files that are part of one of the MCU targets (e.g.
mbed-stm32l4
ormbed-stm32l452xe
. It's as simple as:mbed_disable_mcu_target_file(mbed-stm32l452xe system_clock.c)
Then, you can add your own system_clock.c as part of a custom target. No fuss, no muss!
Impact of changes
It's now possible to replicate the 'override' functionality that custom targets had in Mbed CLI 1 and mbed-cmake!
Migration actions required
None
Documentation
This is documented through the mbed-ce-custom-targets example project.
Pull request type
Test results
I tested this locally by confirming that the L452RE_CUSTOM_CLOCK target builds in the example repo, and system_clock.c from Mbed is not compiled as part of it.
Reviewers