Check login flows only if MSC4190 is not enabled #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the homeserver login flows are checked even if MSC4190 is enabled. However, the `flows` variable is unused when MSC4190 is enabled. This is an unnecessary network call, and also e.g. requires a reverse proxy soley for this purpose if bridges would otherwise directly connect to a homeserver that is delegating OIDC authentication. Closes mautrix#177.
|
This will also close mautrix/telegram#1020 (which is currently closed in error). |
Sharparam
approved these changes
Aug 11, 2025
Sharparam
left a comment
Sharparam
left a comment
There was a problem hiding this comment.
I've tested the same changes on my server and they work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the homeserver login flows are checked even if MSC4190 is enabled. However, the
flowsvariable is unused when MSC4190 is enabled.This is an unnecessary network call, and also e.g. requires a reverse proxy soley for this purpose if bridges would otherwise directly connect to a homeserver that is delegating OIDC authentication.
Closes #177.
Testing, linting, etc
mautrix-googlechatthat usesmautrix-pythonfrom this commit with MSC4190 support. Docker container build here. Messages flow bidirectionally, double puppeting works, etc.