Skip to content

Conversation

@Teebarh
Copy link
Contributor

@Teebarh Teebarh commented Apr 13, 2025

This pull request migrates over the documentation for the Configuration component in the reStructuredText (RST) format. It addresses Issue #60.

@Teebarh Teebarh closed this Apr 15, 2025
@Teebarh Teebarh reopened this Apr 22, 2025
@RCheesley RCheesley self-requested a review April 23, 2025 14:26
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Teebarh thanks for working on this.

There are a lot of Vale issues which need resolving.

Also, please ensure you fix the headings to use the correct length - they must be exactly the same as the text they underline.

Finally, please remove all links. You should be using the :doc: reference for linking to headings, or :ref: on the same page, or using the command make link for external links.

@Teebarh
Copy link
Contributor Author

Teebarh commented Apr 27, 2025

Hi there @Teebarh thanks for working on this.

There are a lot of Vale issues which need resolving.

Also, please ensure you fix the headings to use the correct length - they must be exactly the same as the text they underline.

Finally, please remove all links. You should be using the :doc: reference for linking to headings, or :ref: on the same page, or using the command make link for external links.

Hi @RCheesley! I've made the changes in this commit here.

@favour-chibueze favour-chibueze added the writetechhub Pull requests from writetechhub's team label May 2, 2025
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this builds I noticed the route definitions table extends beyond the edge of the page, I think @favour-chibueze might know how to fix this? If so can we address it in this PR?

image

Otherwise it looks good, thanks @Teebarh for the work on this!

@Teebarh
Copy link
Contributor Author

Teebarh commented May 8, 2025

When this builds I noticed the route definitions table extends beyond the edge of the page, I think @favour-chibueze might know how to fix this? If so can we address it in this PR?

image

Otherwise it looks good, thanks @Teebarh for the work on this!

Thank you! It was a pleasure working on it.

@favour-chibueze
Copy link
Contributor

Screenshot 2025-08-3 at 12 30 13

@RCheesley, I have fixed the table bug. Please review and we can merge the PR if everything looks good.

Sorry for the delay @Teebarh

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Teebarh

@RCheesley RCheesley linked an issue Aug 13, 2025 that may be closed by this pull request
@RCheesley RCheesley merged commit b53c477 into mautic:5.x Aug 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

writetechhub Pull requests from writetechhub's team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write documentation for Configuration component

5 participants