Api.php: getMauticVersion() always returns null due to header key is lower-case

[HerbergSystems]

In Method getMauticVersion():

public function getMauticVersion()`
     {
       $headers = $this->auth->getResponseHeaders();

       if (isset($headers['Mautic-Version'])) {
           return $headers['Mautic-Version'];
       }

       return null;
   }

Unfortunately, the header (at least on our Mautic installation on Debian Buster) is all lower-case: "mautic-version", not "Mautic-Version". So, this method will always return null.

Solution:

Avoid case-sensitive checks on headers here. Simple workaround (could be done better...):

public function getMauticVersion()
   {
       $headers = $this->auth->getResponseHeaders();

       if (isset($headers['Mautic-Version'])) {
           return $headers['Mautic-Version'];
       }
       if (isset($headers['mautic-version'])) {
           return $headers['mautic-version'];
       }

       return null;
   }

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[dennisameling]

Hi @HerbergSystems, thanks for reporting this! I've seen this in other PHP applications before - some webservers seem to convert header keys to lowercase. Could you please test #240? That should fix it!

[HerbergSystems]

Hi Dennis, Thanks for fixing the bug. It worked for me! Best regards Jan Am 24.02.2021 um 20:55 schrieb Dennis Ameling:

…

Hi @HerbergSystems <https://github.com/HerbergSystems>, thanks for reporting this! I've seen this in other PHP applications before - some webservers seem to convert header keys to lowercase. Could you please test #240 <#240>? That should fix it! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#233 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR4AQF5KJWSXY2EAPSLH3GDTAVKRRANCNFSM4WEAZSVQ>.

-- Herberg Systems GmbH Mr. Jan Herberg Geschäftsführer/Managing Director Boschstrasse 23 b 22761 Hamburg - Germany Phone: +49 40 40 11 346-0 Mobile: +49 173 8683 315 Web: http://www.herberg-systems.com Amtsgericht Hamburg Registernummer: HR B 77 140

[Moongazer]

I'm having the same issue on my webserver and can confirm that the solution #240 works, please merge it into the next release, thanks!

Edit:
The reason for the header change in our case is probably the Nginx, which sits as reverse-proxy before the Mautic instance running on Apache.

[escopecz]

Thanks for testing! Please approve the PR itself. Your test may me overlooked in the issues.