-
Notifications
You must be signed in to change notification settings - Fork 3
Updating replace_net_uses()
with new test cases
#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@danielpenas42 Thanks! The first thing you should do is fix the clippy lints ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel! Just some small nitpicks. Also, still looks cargo clippy
still has a few more lints for you to apply.
Hey I tried to fix everything and created a combinational loop to see if it gets it and from what I can tell, it is right. Lmk if anything else looks bad! I also fixed all the clippy I was running the wrong command and didnt show properly all the flaws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks! I had two more nitpicks but I approved so you can merge whenever you want.
replace_net_uses()
with new test cases
Just fixed those problems. I was wondering to merge it do i need to wait for workflow approval or can i do it straight away? |
Yeah it's strange I have to re-approve the CI check run every time. I will try to fix that for next time. Looks good to merge! |
Implemented if statement for replace_net_uses. The tests that we checked over now do pass