Skip to content

Conversation

MilesMcBain
Copy link

@MilesMcBain MilesMcBain commented Feb 3, 2021

Hey there

Thanks for the very cool extension!

I see multiple issues about font size (edit: e.g. #17, #22). I'm no TS/JS developer, but here is a sketch of a way that could be done that would also scale easily to other configurable style elements, e.g. font family and weight.

Thanks!

Was trying to get the no content text to respond to size changes live,
but I see that's not possible without more rework.
},
"docsView.documentationView.fontSize": {
"type": "integer",
"default": 12,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the default be based on the user's editor font size instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a nice way to do this. If I use type integer it's not possible to have undefined default. It defaults to 0.

I could use editor font size if this is 0, but that feels off.

Any ideas on clean ways to do this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using editor font size if 0 is the standard way vscode does it. look at the built in font size configuration settings. better just to use 0 like you said so it conforms to the rest of vscode.
image

@FilipAndersson245
Copy link

@mattbierner what is needed to close this PR? it would be very nice to be able to configure the font size.

@emlautarom1
Copy link

Also asking if we could merge this one out!

@nagoli
Copy link

nagoli commented Sep 12, 2023

Waiting for the feature to be accepted, you can simply change the text size in the css of the extension : ~/.vscode/extensions/bierner.docs-view-0.0.11/media/main.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants