-
Notifications
You must be signed in to change notification settings - Fork 23
Allow configuration of text size #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Was trying to get the no content text to respond to size changes live, but I see that's not possible without more rework.
}, | ||
"docsView.documentationView.fontSize": { | ||
"type": "integer", | ||
"default": 12, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the default be based on the user's editor font size instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know a nice way to do this. If I use type integer it's not possible to have undefined default. It defaults to 0.
I could use editor font size if this is 0, but that feels off.
Any ideas on clean ways to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattbierner what is needed to close this PR? it would be very nice to be able to configure the font size. |
Also asking if we could merge this one out! |
Waiting for the feature to be accepted, you can simply change the text size in the css of the extension : ~/.vscode/extensions/bierner.docs-view-0.0.11/media/main.css |
Hey there
Thanks for the very cool extension!
I see multiple issues about font size (edit: e.g. #17, #22). I'm no TS/JS developer, but here is a sketch of a way that could be done that would also scale easily to other configurable style elements, e.g. font family and weight.
Thanks!