Remove origin from events and assertions
#1293
Conversation
Related to: matrix-org/matrix-spec#998 Setting `origin` field in PDUs is not required anymore, so I've removed assertions and assignments to this field.
|
Apparently, Dendrite is no happy with this change. |
Probably worth opening a Dendrite bug (if there isn't one for this already).
Sounds reasonable. |
If you take this path, please can you comment the places we set |
lib/SyTest/Federation/Client.pm
Outdated
| auth_events content depth prev_events room_id sender | ||
| state_key type ) ), | ||
|
|
||
| # The spec does not require the origin field, but Dendrite does. This can be removed |
There was a problem hiding this comment.
@richvdh Is this similar to what you were expecting? Let me know if you want me to change the message. Thanks!
|
matrix-org/dendrite#2737 Please hold off on doing anything until we get these landed. |
This reverts commit aed2b10.
There was a problem hiding this comment.
Right, this should be OK now that we've fixed Dendrite. I have reverted aed2b10 — LGTM if CI is green.
4 participants
Related to: matrix-org/matrix-spec#998
Setting
originfield in events/PDUs is not required any more, so I've removed assertions and assignments to this field.