This repository was archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add a linting script #5627
Merged
Merged
Add a linting script #5627
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
70bff52
Add a linting script
anoadragon453 325bfc0
Add changelog
anoadragon453 e2f9509
Fix linting steps
anoadragon453 e16b9b1
Explain script, restrict black run dirs
anoadragon453 d71083f
set -e
anoadragon453 f4dc17d
move set -e to correct location
anoadragon453 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add `lint.sh` to the scripts-dev folder which will run all linting steps required by CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #!/bin/sh | ||
| # | ||
| # Runs linting scripts over the local Synapse checkout | ||
| # isort - sorts import statements | ||
| # flake8 - lints and finds mistakes | ||
| # black - opinionated code formatter | ||
|
|
||
| set -e | ||
|
|
||
| isort -y -rc synapse tests scripts-dev scripts | ||
anoadragon453 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| flake8 synapse tests | ||
| python3 -m black synapse tests scripts-dev scripts | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.