Skip to content

allow loading poetry path #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/v2
Choose a base branch
from
Open

allow loading poetry path #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ inputs:
deps.
required: false
default: "true"
load-poetry-path:
description: >
Set to "true" to add the path to the poetry executable to the PATH.
required: false
default: "false"
Comment on lines +37 to +41
Copy link
Contributor

@MadLittleMods MadLittleMods Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not default to true as a sane default?

Copy link
Contributor Author

@gaelgatelement gaelgatelement Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly wanted to avoid changing the action default behaviour. WDYT?

Copy link
Contributor

@MadLittleMods MadLittleMods Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like nothing would change for existing consumers of the action if we default to true.

runs:
using: composite
steps:
Expand Down Expand Up @@ -112,6 +117,11 @@ runs:
ARG_INSTALL: "${{ inputs.install-project != 'true' && '--no-root' || '' }}"
working-directory: ${{ inputs.working-directory }}

- name: Load poetry path
run: |
echo "$(poetry env info -p)/bin" >> "${GITHUB_PATH}"
if: "${{ inputs.load-poetry-path == 'true' }}"
Comment on lines +120 to +123
Copy link
Contributor

@MadLittleMods MadLittleMods Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative, what about just using poetry run xxx?

Copy link
Contributor Author

@gaelgatelement gaelgatelement Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also works, but third-party scripts might expect the "binary" name to be available without having to go through poetry. (typically the case when installing ansible for example)

Copy link
Contributor

@MadLittleMods MadLittleMods Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that an actual use case yet? Link?


# For debugging---let's just check what we're working with.
- name: Dump virtual environment
run: |
Expand Down