-
Notifications
You must be signed in to change notification settings - Fork 416
MSC3786: Add a default push rule to ignore m.room.server_acl events
#3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c109875
Add a default push rule to ignore `m.room.server_acl` events
SimonBrandner 0c78f6e
Update MSC number
SimonBrandner 94ac57a
Add prefix `.`
SimonBrandner 53d42f7
Link to spec
SimonBrandner c86713e
Be more explicit about why the rule is needed
SimonBrandner b28af33
Clarify push rule ordering
SimonBrandner 5d47fe4
Don't rely on unmerged MSCs for ordering
SimonBrandner 0170475
Be even more explicit about why we need this
SimonBrandner 7307bcb
Improve wording
SimonBrandner 3cbd4d2
Improve wording
SimonBrandner d9bcf88
Improve wording
SimonBrandner a0baa9d
Add missing period
SimonBrandner bb6664a
Add spec link
SimonBrandner af56f02
Remove `when merged`
SimonBrandner bc4440d
Remove `dont_notify`
SimonBrandner 233efdb
Check `state_key`
SimonBrandner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # MSC3786: Add a default push rule to ignore `m.room.server_acl` events | ||
|
|
||
| `m.room.server_acl` events allow for expressing which servers can participate in | ||
| a room. Room server ACLs aren't something the user should have to worry about, | ||
| so these events should not trigger notifications; however right now they *do* | ||
| trigger notifications, if the user has the room rule set to `notify` (`All | ||
| messages` in Element). | ||
|
|
||
| Additionally, these events are often sent quite frequently during spam attacks, | ||
| which causes the users to be overwhelmed by | ||
| notifications. (See <https://github.com/vector-im/element-web/issues/20788>.) | ||
|
|
||
| Due to these problems, this MSC proposes a new push rule to ignore these events. | ||
| The new push rule is analogous to `.m.rule.member_event` (see <https://spec.matrix.org/v1.2/client-server-api/#default-override-rules>), or `.m.rule.reaction` | ||
| (from [MSC2153](https://github.com/matrix-org/matrix-spec-proposals/pull/2153) | ||
| or [MSC2677](https://github.com/matrix-org/matrix-spec-proposals/pull/2677)). | ||
|
|
||
| ## Proposal | ||
|
|
||
| A new [default override | ||
| rule](https://spec.matrix.org/v1.2/client-server-api/#default-override-rules) is | ||
| to be added that ignores `m.room.server_acl` events: | ||
|
|
||
| ```json | ||
| { | ||
| "rule_id": ".m.rule.room.server_acl", | ||
| "default": true, | ||
| "enabled": true, | ||
| "conditions": [ | ||
| { | ||
| "kind": "event_match", | ||
| "key": "type", | ||
| "pattern": "m.room.server_acl" | ||
| }, | ||
| { | ||
| "kind": "event_match", | ||
| "key": "state_key", | ||
| "pattern": "" | ||
| } | ||
| ], | ||
| "actions": [] | ||
| } | ||
| ``` | ||
|
|
||
| This new push rule is inserted immediately after `.m.rule.tombstone`. | ||
|
|
||
| ## Unstable prefix | ||
|
|
||
| During development, `.org.matrix.msc3786.rule.room.server_acl` is to be used | ||
| instead of `.m.rule.room.server_acl`. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.