This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Prepare for Element Call integration #9224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a role to Tooltip was motivated by React Testing Library's reliance on accessibility-related attributes to locate elements.
The ReadyWatchingStore constructor previously had a chance to immediately call onReady, which was dangerous because it was potentially calling the derived class's onReady at a point when the derived class hadn't even finished construction yet. In normal usage, I guess this never was a problem, but it was causing some of the tests I was writing to crash. This is solved by separating out the onReady call into a start method.
to reflect the fact that they're slated for removal, and to not clash with the new Call code.
robintown
added
the
T-Task
2 tasks
Call is an abstract class that currently only has a Jitsi implementation, but this will make it easy to later add an Element Call implementation.
These are no longer used by the new Jitsi call implementation, and can be removed.
robintown
force-pushed
the
ec-video-rooms
branch
from
6dcdfed to
784ab8a
Compare
Contributor
SimonBrandner
left a comment
SimonBrandner
left a comment
There was a problem hiding this comment.
This is looking really great! It's awesome to see the EC integration slowly taking shape!
SimonBrandner
requested review from
dbkr
and removed request for
dbkr and
weeman1337
robintown
commented
Aug 29, 2022
SimonBrandner
approved these changes
Aug 30, 2022
Contributor
SimonBrandner
left a comment
SimonBrandner
left a comment
There was a problem hiding this comment.
LGTM - thank you!!
dbkr
approved these changes
Aug 30, 2022
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
I think this looks plausible, although for next time I'd definitely suggest doing renames, refactors and new functionality in separate PRs as the size of this PR makes it quite hard to review the new code.
Member
Author
|
Right, apologies for getting a little carried away. I was intending to at least separate the renaming changes at one point, but must've forgotten that was an option, I guess. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring of the video rooms code, with the goal of making it reusable for more than just video rooms (meaning, group calls and 1:1 calls as well), and greatly simplifying the task of integrating Element Call into the app as another call backend. To accomplish this, VideoChannelStore was renamed and split up into Call and CallStore, and all associated components have been updated to reflect this simpler architecture. All the pieces of the legacy 1:1 code have been renamed to 'LegacyCall', to reflect the fact that they're slated for eventual removal.
I recommend reviewing the individual commits rather than the overall diff.
Depends on element-hq/element-web#23158
Towards element-hq/element-web#22964
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.