Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Device Manager - add new labsed session manager screen (PSG-636) #9119

Merged
merged 13 commits into from
Aug 8, 2022
Merged

Device Manager - add new labsed session manager screen (PSG-636) #9119

merged 13 commits into from
Aug 8, 2022

Conversation

@kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Jul 29, 2022 •
edited by github-actions bot
Loading

  • add labs flag for new device manager
  • add basic generic SettingsTab component (based on figma)
  • add stubbed 'Sessions' tab to user settings dialog

Includes #9118

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 29, 2022
@kerryarchibald kerryarchibald force-pushed the psg-636/device-manager-labs-flag branch from 73a9ad6 to 3dee437 Compare August 8, 2022 06:09
@kerryarchibald kerryarchibald marked this pull request as ready for review August 8, 2022 06:09
@kerryarchibald kerryarchibald requested a review from a team as a code owner August 8, 2022 06:09
SimonBrandner
SimonBrandner approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kerryarchibald kerryarchibald mentioned this pull request Aug 8, 2022
Merged
3 tasks
@kerryarchibald kerryarchibald enabled auto-merge (squash) August 8, 2022 09:05
@kerryarchibald kerryarchibald disabled auto-merge August 8, 2022 11:00
@kerryarchibald kerryarchibald enabled auto-merge (squash) August 8, 2022 11:00
@kerryarchibald kerryarchibald mentioned this pull request Aug 8, 2022
Merged
3 tasks
@kerryarchibald kerryarchibald merged commit ed67aec into develop Aug 8, 2022
@kerryarchibald kerryarchibald deleted the psg-636/device-manager-labs-flag branch August 8, 2022 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@turt2live turt2live Awaiting requested review from turt2live turt2live is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@SimonBrandner SimonBrandner SimonBrandner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kerryarchibald @SimonBrandner