Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 30, 2022

This PR tidies up _FilePanel.scss, before removing :not() pseudo class and fixing the timestamp position by moving a class out of the pseudo class on _EventTile.scss.

Signed-off-by: Suguru Hirahara [email protected]

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Jun 30, 2022

.mx_MessageTimestamp {
flex: 1 0 0;
text-align: right; // FIXME: .mx_EventTile:not([data-layout=bubble]) .mx_MessageTimestamp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been effective because of mx_EventTile:not([data-layout=bubble]) .mx_MessageTimestamp on _EventTile.scss.

before

@luixxiul luixxiul marked this pull request as ready for review June 30, 2022 14:38
@luixxiul luixxiul requested a review from a team as a code owner June 30, 2022 14:38
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the Netlify deployment, LGTM.

Thank you for your contribution @luixxiul 👍

@weeman1337 weeman1337 merged commit 4b17307 into matrix-org:develop Jul 4, 2022
@luixxiul luixxiul deleted the FilePanel branch July 4, 2022 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants