This repository was archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 815
MSC2545 support proof-of-concept #8897
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
turt2live
reviewed
Jun 25, 2022
Member
turt2live
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearing code review while draft
Signed-off-by: ckie <[email protected]>
Signed-off-by: ckie <[email protected]>
Signed-off-by: ckie <[email protected]>
Signed-off-by: ckie <[email protected]>
Signed-off-by: ckie <[email protected]>
|
@ckiee is this PR still active? We want to consolidate the amount of competing PRs in order for the feature to move forward. Product is blocking #9240 since they have to review all competing PRs that are open. If not, please close this PR so #9240 can go forward. We support MSC2545 in that PR and can add further features once merged. |
Contributor
Author
|
Closing in favor of #9240 since it is clearly superior, though it is worth clearly noting that this PR implements the sticker portion of 2545, which has considerable overlap with the emojo section. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
T-Enhancement
New features, changes in functionality, performance boosts, user-facing improvements
Z-Community-PR
Issue is solved by a community member's PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bazillion things wrong with this code, but I just wanted to put it out there in case anyone else would like to work on it, and just to get feedback about the idea.
Type: enhancement
Here's what your changelog entry will look like:
✨ Features
TODO
Blockers
mediaFromMxcstuff would probably break in encrypted rooms.matrix-js-sdkgetAccountData.Cookiestickerpicker.Future