Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jun 5, 2022

Towards element-hq/element-web#22235


This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Šimon Brandner <[email protected]>
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 Looks good. Can you double-check my two comments if these changes are okay? They are doing more than defining visibilities like mentioned in the issue description.

@SimonBrandner SimonBrandner merged commit 125a265 into develop Jun 6, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/task/plat-type-1 branch June 6, 2022 06:31
JanBurp pushed a commit to JanBurp/matrix-react-sdk that referenced this pull request Jun 14, 2022
* Improve Typescript in `BasePlatform`

Signed-off-by: Šimon Brandner <[email protected]>

* `installUpdate()` should not be abstract

Signed-off-by: Šimon Brandner <[email protected]>
t3chguy pushed a commit that referenced this pull request Jun 14, 2022
* Improve Typescript in `BasePlatform`

Signed-off-by: Šimon Brandner <[email protected]>

* `installUpdate()` should not be abstract

Signed-off-by: Šimon Brandner <[email protected]>
(cherry picked from commit 125a265)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants