Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 5, 2022

Normal Compact
Before before before1
After after after1

Closes element-hq/element-web#22434
Closes element-hq/element-web#22448

Requires #8711 due to cascading effect: element-hq/element-web#22434 (comment)
Retry of #8725

This PR moves style rules of compact modern layout from _GroupLayout.scss in order to enable the compact layout on both TimelineCard with a maximized widget and ThreadPanel (threads list and thread view).

Signed-off-by: Suguru Hirahara [email protected]

type: enhancement

Notes: Enable compact modern layout on the right panel


This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 5, 2022
@luixxiul luixxiul changed the title Move EventTile style rules of compact modern layout from _GroupLayout.scss Move EventTile style rules of compact modern layout, enabling it on the right panel as well Jun 5, 2022
luixxiul added 9 commits June 16, 2022 03:12
- EventTile_avatar
- EventTile_line
- EventTile_reply

Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
This is required for enabling the compact modern layout on ThreadPanel and ThreadView.

Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
@luixxiul luixxiul marked this pull request as ready for review June 15, 2022 18:54
@luixxiul luixxiul requested a review from a team as a code owner June 15, 2022 18:54
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane - thanks!

@SimonBrandner SimonBrandner merged commit c4460d8 into matrix-org:develop Jun 18, 2022
@luixxiul luixxiul deleted the MatrixChat_useCompactLayout branch June 18, 2022 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact modern layout should be enabled on the right panel as well Move style rules of MatrixChat_useCompactLayout from _GroupLayout.scss
2 participants